Improve nix flake#200
Conversation
Dependencies are already available in hsPkgs, so they don't need to be additionally passed to callCabal2Nix's last argument
Basically -- manually resolve the link. callCabal2Nix didn't like the link. Other modules here don't use links, so I thought it'd be ok if dataframe-persistent didn't either.
There was a problem hiding this comment.
This is a little confusing. I updated the LICENSE in dataframe-persistent from a link to the dataframe license to a regular file containing the text of the dataframe license. That was important for callCabal2Nix reasons.
However, I'm not sure it was a valid thing to do -- dataframe-persistent claims to be licensed as GPL-3.0-or-later. dataframe claims to be licensed under the MIT license. I'm pretty sure those aren't the same license, but in the repo the two libraries shared the same license text.
| hsPkgs = pkgs.haskellPackages.extend (self: super: { | ||
| granite = self.callCabal2nix "granite" granitePkg { }; | ||
| dataframe-fastcsv = self.callCabal2nix "dataframe-fastcsv" ./dataframe-fastcsv { | ||
| inherit parallel; |
There was a problem hiding this comment.
It was apparently unnecessary to pass these deps explicitly, since the dependencies are already present in the packages defined here
|
I must admit I don't pay too much attention to the license stuff. @Shimuuar gave me a heads up last time and I changed it. Thanks for this. |
See comment here: #200 (comment) On Discord, we discussed that there's no specific reason for dataframe-persistent to be GPL-licensed, so for commercial compatibility, bumping to a library consistent with the rest of the dataframe artifacts
2 participants
graniteso nix build works at alldataframe-persistentin package outputsThis PR doesn't include either nix-driven CI or
dataframe-hasktorchin outputs. Both of those would be good someday, but last time I tried to buildhasktorchanything I had a rough time.